Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 8, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49183

Staging Links

  • reference/release-notes
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 8, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 66719b3
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67f5851ef1adae00087b641f
    😎 Deploy Preview https://deploy-preview-251--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi requested a review from jordan-smith721 April 8, 2025 19:32
    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    more performant deletion of files with multiple revisions.
    - ``AsyncMongoClient`` objects no longer perform DNS resolution for ``mongodb+srv://``
    connection strings on creation. To avoid blocking the ``asyncio`` loop, {+driver-short+}
    now defers teh resolution until the client is first connected.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    now defers teh resolution until the client is first connected.
    now defers the resolution until the client is first connected.

    @mcmorisi mcmorisi merged commit fa74e69 into mongodb:master Apr 8, 2025
    2 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-49183-4.12 branch April 8, 2025 20:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants